fix: secrets oauth skip getOwner#412
Closed
anirudhwarrier wants to merge 1 commit into
Closed
Conversation
anirudhwarrier
commented
May 4, 2026
| func ShouldSkipGetOwner(cmd *cobra.Command) bool { | ||
| switch cmd.Name() { | ||
| case "help": | ||
| path := cmd.CommandPath() |
Collaborator
Author
There was a problem hiding this comment.
cre help is listed under isLoadSettings’s exclusions in cmd/root.go, so that path does not call AttachSettings / loadWorkflowSettings at all. In practice ShouldSkipGetOwner never runs for normal cre help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVSVCS-4808
Refined logic for skipping owner retrieval:
ShouldSkipGetOwnerto check full command paths and handle additional cases: now skips forcre workflow hash, forcre workflow simulatewhen--broadcastis false or unset, and for anycre secrets ...command when--secrets-authis set tobrowser.TestShouldSkipGetOwnerfor variouscre secretscommand scenarios, specifically covering the new logic for skipping when--secrets-authisbrowser.